DJ VinylTouch
The Pro and Performance Skins have the ability to show 4 full decks on the screen, but this does take up quite a bit of space.
It would be nice/potentially more space saving, to add a 2 deck swap mechanism, where the left side shows either deck 1 or 3and the right side shows either deck 2 or 4 (based on which deck is selected for jog manipulation, like how the DDJ 1000 works for e.g.).
There are existing alternative skins that already do this (Vanced GT comes to mind as a concrete example), but it would be nice if the default skin had this as well.
It would be nice/potentially more space saving, to add a 2 deck swap mechanism, where the left side shows either deck 1 or 3and the right side shows either deck 2 or 4 (based on which deck is selected for jog manipulation, like how the DDJ 1000 works for e.g.).
There are existing alternative skins that already do this (Vanced GT comes to mind as a concrete example), but it would be nice if the default skin had this as well.
Inviato Fri 20 Sep 24 @ 2:39 am
locoDog
custom_button
invert_deck
been possible for a long time
invert_deck
been possible for a long time
Inviato Fri 20 Sep 24 @ 2:50 am
DJ VinylTouch
So I didn.t know about this 🍺.
However, it doesn't seem to work right for the default skin in Performance mode (the waveform just disappears). It seems to work correctly for Pro.
However, it doesn't seem to work right for the default skin in Performance mode (the waveform just disappears). It seems to work correctly for Pro.
Inviato Fri 20 Sep 24 @ 3:43 am
locoDog
Yeah vertical [ the other performance orientation is fine] is slightly different, to me looking at the default skins there was a development in design choices thru the skins [or maybe different people did different skins]
in the placing decks bit it needs a small edit [conditional visibility] and a couple of extra lines [for decks 3&4]
becomes
if you wanted to be fussy you could panelgroup the sides to remove 2 queries but, meh 2 queries....
I could write it up proper if you really wanted. But it means a bit more a complicated swap script
in the placing decks bit it needs a small edit [conditional visibility] and a couple of extra lines [for decks 3&4]
<panel visibility="not browser_zoom">
<panel name="deck_vertical">
<panel class="deckleft" panelname="deck1" deck="1"/>
<panel class="deckright" panelname="deck2" deck="2"/>
becomes
<panel visibility="not browser_zoom">
<panel name="deck_vertical">
<panel class="deckleft" panelname="deck1" deck="1" visibility="deck 1 leftdeck"/>
<panel class="deckright" panelname="deck2" deck="2" visibility="deck 2 rightdeck"/>
<panel class="deckleft" panelname="decku3" deck="3" visibility="deck 3 leftdeck"/>
<panel class="deckright" panelname="decku4" deck="4" visibility="deck 4 rightdeck"/>
if you wanted to be fussy you could panelgroup the sides to remove 2 queries but, meh 2 queries....
I could write it up proper if you really wanted. But it means a bit more a complicated swap script
Inviato Fri 20 Sep 24 @ 5:13 am
DJ VinylTouch
@locodog thanks for providing that... I actually was going to look ag how it was done in other skins (the Pro skin has it right) and just replicate that. I'd also havr to look into whether or not the rack panels swap properly too (4 deck mode gives the option to select the deck it shows, but 2 decks is collapsed).
However, it does seem like a bug/oversight in the performance skin to me (unless I'm misunderstanding the intended direction).
However, it does seem like a bug/oversight in the performance skin to me (unless I'm misunderstanding the intended direction).
Inviato Fri 20 Sep 24 @ 12:00 pm
DJ VinylTouch
So after further inspection, I'm almost sure that the Performance Vertical skin is misbehaving with invert_deck. When I execute invert_deck (controller deck switch (DDJ-1000) or verb), and the FX rack is open, the FX Rack panel's widgets disappear completely for that side as well.
Inviato Wed 25 Sep 24 @ 1:52 am
locoDog
It's not a bug, it's just how it was designed. It was never intended to be used as a swap skin so some things weren't catered for.
To sort it out it's just 4 visibility cases in the fx & mix rack that need this removing
video rack has a minor tweak needed too, but it's not a functional issue.
To sort it out it's just 4 visibility cases in the fx & mix rack that need this removing
&& var_not_equal '@$4decks' 0
video rack has a minor tweak needed too, but it's not a functional issue.
Inviato Wed 25 Sep 24 @ 2:20 am
DJ VinylTouch
So I already got that far...there are more problems with that edit that would require further edits/reorgs...selecting other racks it seems resets the view (decks, FX racks and others).
Tbh I agree that i could be a design decision, but it's a bit weird to me especially as the manual doesn't really say not to use the variant with 4 deck controllers, and one can experience these anomalies and would be confused. The skin organizes/potentially minimizes space usage very nicely as well.
At the very least I think the original request is still valid (provide a 2 deck swap version of the Vertical Performance skin).
Tbh I agree that i could be a design decision, but it's a bit weird to me especially as the manual doesn't really say not to use the variant with 4 deck controllers, and one can experience these anomalies and would be confused. The skin organizes/potentially minimizes space usage very nicely as well.
At the very least I think the original request is still valid (provide a 2 deck swap version of the Vertical Performance skin).
Inviato Wed 25 Sep 24 @ 2:45 am
locoDog
it's just the nbdecks condition at the start of the xml, un/calling a rack reloads a skin [to resize the browser] and that calls the condition. Remove that and it doesn't reset left/right deck
I've made all the edits here.
I've made all the edits here.
Inviato Wed 25 Sep 24 @ 4:25 am
DJ VinylTouch
Thanks locodog for the updates. I think the edits need to be done/checked to make sure it still functions as before in 4 deck mode. I'll play around with it more later.
Inviato Wed 25 Sep 24 @ 1:31 pm
DJ VinylTouch
@locodog so I did get this to work properly for the Vertical variant of the skin base on your tips (2 deck implies 2 deck swap) and I added a little panel to the mixer rack to host, record, broadcast and file buttons similar to the Pro skin.
I guess I could also look into the edits the other versions of the Performance skin to be more complete but what I have currently fits my needs perfectly.
Thank you for the help/suggestions 🍺.
I guess I could also look into the edits the other versions of the Performance skin to be more complete but what I have currently fits my needs perfectly.
Thank you for the help/suggestions 🍺.
Inviato Thu 26 Sep 24 @ 10:45 pm
locoDog
What did you do with the video rack? I changed mine to left|rightvideo instead of left|rightdeck.
Inviato Thu 26 Sep 24 @ 11:04 pm
DJ VinylTouch
I actually didn't have to mess with existing logic much at all...the existing logic was largely reused (swapping of the video preview panel (before and after video activation) seemed like it was already handled correctly by existing panel conditions) - I just added a matching button for decks 3 and 4 to identify the decks that are being referenced (text = Source C and Source D respectively), and I may have removed/added some && var_equal '@$4decks' 0 and && var_not_equal '@$4decks' 0 conditions accordingly, but it seemed largely taken care of from what I saw (unless I'm misunderstanding the problem).
Inviato Thu 26 Sep 24 @ 11:29 pm